feat(android): setup uniffi infra #8828
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| let hash = Stamp::mint( | ||
| unsafe { String::from_raw_parts(resource.cast_mut().cast(), length, length) }, | ||
| Some(bits), |
There was a problem hiding this comment.
The current use of String::from_raw_parts is unsafe and could lead to undefined behavior since it takes ownership of the raw pointer without proper lifetime guarantees. Consider using CStr::from_ptr(resource).to_str().unwrap_or_default() instead, which provides safe conversion from a C string pointer to a Rust string while properly handling null terminators and invalid UTF-8.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9651325. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8828 +/- ##
=======================================
Coverage 70.19% 70.19%
=======================================
Files 550 550
Lines 34005 34005
Branches 3052 3052
=======================================
Hits 23871 23871
Misses 9762 9762
Partials 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Brooooooklyn
force-pushed
the
11-14-feat_android_native_module
branch
2 times, most recently
from
5b57ec0
to
b96bf72
Compare
Brooooooklyn
changed the title
Brooooooklyn
force-pushed
the
11-14-feat_android_native_module
branch
from
b96bf72
to
2288985
Compare
Brooooooklyn
force-pushed
the
11-14-feat_android_native_module
branch
from
2288985
to
9651325
Compare
No description provided.